fix: avoid cyclic initialisation *warning* between Predef, Manifest and ManifestFactory
#23903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nifestFactory`
We get the following warning in the test suite before this change
```scala
at 109: Cyclic initialization: object Predef -> object Manifest -> object ManifestFactory -> object Predef. Calling trace:
├── object Manifest { [ Manifest.scala:76 ]
│ ^
├── val Byte: ManifestFactory.ByteManifest = ManifestFactory.Byte [ Manifest.scala:86 ]
│ ^^^^^^^^^^^^^^^
├── object Predef extends LowPriorityImplicits { [ Predef.scala:109 ]
│ ^
├── val Manifest = scala.reflect.Manifest [ Predef.scala:210 ]
│ ^^^^^^^^^^^^^^^^^^^^^^
├── object ManifestFactory { [ Manifest.scala:171 ]
│ ^
└── private[this] val ObjectTYPE = classOf[java.lang.Object] [ Manifest.scala:323 ]
```
hamzaremmal
changed the title
Predef, Manifest and ManifestFactoryPredef, Manifest and ManifestFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new stdlib fully compiled with Scala 3, we get the following warning in the test suite before this change
Since
Predef.classOfis magic, we can safely ignore these fields in the init checker.